Re: [lime-dev] Comments on hardware-detection (was: Issues with the pre-compiled images)

On 12/08/14 08:48, Gioacchino Mazzurco wrote: as it stands now, it actually covers *less* cases than my approach :) + TITLE:=Configure eth1 as wan interface if present in wdr3600 / wdr4300, there's no eth1, but openwrt correctly configures eth0.2 as wan by default. in my point of view: * having a broken wan port on devices that (with vanilla openwrt) normally have a working wan port, qualifies as a *bug* / regression on our part (over what openwrt offers). * having a way to easily assign "wan" function to custom ports, qualifies as a *feature* / wishlist, something that openwrt does not offer currently. i have not encountered that bug (i'm writing with a tl-wdr3600 next to my arm). Asked pau about the steps to reproduce it or the symptoms, and he said he's not sure it's still a problem on current builds. i agree my approach was not configurable, since that wasn't my point (cf. the bullets above). I thought configurability was a wishlist feature, and I wanted to fix the bug. I like the "wan" proto idea, but in it's current implementation, it adds configurability, but regresses to the bug, so i think it's a bad tradeoff :P i think we can combine both approaches, like you suggested: make the "wan" proto respect "openwrt" wan on firstboot, and after that allow the user to modify the /etc/config/lime abstraction and have that propagated on-demand into the lower layer /etc/config/network. in other words, make lime-config behave differently if it's running on firstboot or afterwards: * on firstboot, it will kinda "look" at what openwrt configured (see what interfaces set as lan, wan, wifi, etc), and create an /etc/config/lime that respects and reflects that firstboot (upstream-aligned) state. * on every other run afterwards, it will no longer respect what's set outside of /etc/config/lime, instead enforcing it's own "view" of what the config should be. so, if i flash a tl-wdr3600, after firstboot /etc/config/lime will have config net eth0.2 list protocols 'wan' while if i flash a tl-wdr3500, i will get a /etc/config/lime with config net eth1 list protocols 'wan' and afterwards, i can touch that "config net" section to turn that port into something else, or assign proto wan to other port, or whatever, and run lime-config again, which will (only then) overwrite /etc/config/network to put it simple, i think on firstboot we must respect as much as possible openwrt default config, if we want to run on as much hardware as possible. we will never outsmart openwrt devs in terms of board compatibility. in concrete terms, i'm talking about this: http://pastebin.com/24MEx5V0 respecting what that file produces on firstboot is not hard, but trying to reimplement all that logic in "our" scripts will definitely be unmanageable. Then come! spring will start here in about a month :D in the meantime, i think a mumble meeting definitely can't hurt, what about next week? say, tuesday 2014/08/14 at 13pm UTC like last time cheers!