On 25/12/14 10:43, Gioacchino Mazzurco wrote:
On Friday, December 19, 2014 08:23:02 PM Pau wrote:
1) The firewall problem is not yet fixed, so raw
images which does not
include the firewall packet are not properly working.
In fact the code doesn't really take advantage of openwrt firewall, we actually
depend on it on arbitrary choice
https://github.com/libre-mesh/lime-packages/blob/develop/packages/lime-prot…
i don't like openwrt firewall, and in my experience has caused more problems
than solutions, I propose to abstract the linked code so it doesn't depend on
unnecessary openwrt firewall
obviously, i disagree :)
lime-init framework duplicated functionality already present in stock
openwrt, so it added complexity unnecesarily
what i did in:
https://github.com/libre-mesh/lime-packages/commit/854c93744e8e85c98be67dc9…
was put firewall-related things into /etc/firewall.user.d/
and random stuff in /etc/rc.local.d/, which i think makes much more
sense to a newcomer, than an extra init system which is built on top of
/etc/init.d/ and even has it's own semantics (.start / .stop suffixes?)
"firewall" package is well-thought, well integrated into uci system,
flexible enough to do many many things, and very easy to "disable" so
that it stays out of the way:
i don't recall any such "problem" since this commit
https://github.com/libre-mesh/lime-packages/commit/c415a32e8e77904e11ca2033…
which basically makes firewall package block nothing by default, unless
asked to.
i think being able to ship a "dormant" firewall package only brings
benefits, and so far no problems.
Unless you point out one such problems, i'll tag your phrase "has caused
more problems than solutions" as [weasel words] :P
don't get me wrong, i also expent much time and headaches "fighting"
against openwrt default firewall, but i finally understood it was best
to install it and ship a please-block-nothing config, than try to avoid it.
if not, there's sometimes a post-flash opkg install that will pull it as
a dependency, or you will (at some point) want to configure an ipv4 port
forwarding, and then you'll miss the simplicity/flexibility of
/etc/config/firewall
In any case it should be a dependency of lime-proto-anygw and not of lime-
system
it's a dependency of lime-proto-bmx6 as well
https://github.com/libre-mesh/lime-packages/blob/develop/packages/lime-prot…
i've pushed a commit to hotfix this in release/14.08 (since at it stands
now, release/14.08 is broken)
https://github.com/libre-mesh/lime-packages/commit/578dc314b61c27a8deca735f…
if nobody objects until tomorrow i'll merge it in develop as well
cheers!